-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel with recent notifications #8465
base: main
Are you sure you want to change the base?
Conversation
jprochazk
commented
Dec 15, 2024
•
edited
Loading
edited
- Closes Panel with recent log/notification messages #4304
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it! ❤️ FINALLY
Info, | ||
Warning, | ||
Error, | ||
Success, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document the difference between Info
and Success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what the difference is, it came from ToastKind
which was also undocumented. I guess someone wanted to use a different color?
This picks up stuff we didn't show in the viewer at all so far :/ This is also there on main, but there it's not shown as a toast notification Edit: this is likely related to emil's comment here #8465 (comment) |
Quick UX feedback: I would expect the panel to close when I click outside of it. |
All of the following scenarios now work as expected:
The layout for individual notifications is still pretty gnarly, but it doesn't seem like I'll be able to use |
...or maybe I just flip the layout a bit and it will be good enough? |