Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel with recent notifications #8465

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Dec 15, 2024

@jprochazk jprochazk added enhancement New feature or request ui concerns graphical user interface include in changelog do-not-merge Do not merge this PR labels Dec 15, 2024
Copy link

github-actions bot commented Dec 15, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
7ff684e https://rerun.io/viewer/pr/8465 +nightly +main

Note: This comment is updated whenever you push a commit.

@jprochazk jprochazk removed the do-not-merge Do not merge this PR label Dec 16, 2024
@jprochazk jprochazk marked this pull request as ready for review December 16, 2024 12:28
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! ❤️ FINALLY

crates/viewer/re_ui/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Comment on lines 12 to 15
Info,
Warning,
Error,
Success,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the difference between Info and Success

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the difference is, it came from ToastKind which was also undocumented. I guess someone wanted to use a different color?

crates/viewer/re_ui/src/notifications.rs Outdated Show resolved Hide resolved
crates/viewer/re_ui/src/notifications.rs Outdated Show resolved Hide resolved
crates/viewer/re_ui/src/notifications.rs Outdated Show resolved Hide resolved
crates/viewer/re_ui/src/notifications.rs Outdated Show resolved Hide resolved
crates/viewer/re_ui/src/notifications.rs Outdated Show resolved Hide resolved
crates/viewer/re_ui/src/notifications.rs Show resolved Hide resolved
crates/viewer/re_viewer/src/app.rs Show resolved Hide resolved
@Wumpf
Copy link
Member

Wumpf commented Dec 17, 2024

This picks up stuff we didn't show in the viewer at all so far :/

Firefox windows:
image

This is also there on main, but there it's not shown as a toast notification

Edit: this is likely related to emil's comment here #8465 (comment)

@Wumpf
Copy link
Member

Wumpf commented Dec 17, 2024

it also needs a scroll bar 🤔 Can't reach the clear all anymore
image
(I provoked the error a bunch of time here, just as an example)

@jprochazk jprochazk added the do-not-merge Do not merge this PR label Dec 17, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Dec 17, 2024

Quick UX feedback: I would expect the panel to close when I click outside of it.

@jprochazk
Copy link
Member Author

All of the following scenarios now work as expected:

  • Click toggle button: Panel is open
  • Click toggle button twice: Panel is closed
  • Click toggle button, click inside the panel: Panel is open
  • Click toggle button, click outside of panel: Panel is closed
  • Click toggle button, press escape: Panel is closed
  • Select something in the selection/time panel, click toggle button, press escape: Panel is closed, selection is preserved

The layout for individual notifications is still pretty gnarly, but it doesn't seem like I'll be able to use egui_flex for that, as it doesn't support max-width combined with flex-grow

@jprochazk
Copy link
Member Author

...or maybe I just flip the layout a bit and it will be good enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Do not merge this PR enhancement New feature or request include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel with recent log/notification messages
5 participants